[U-Boot] [PATCH] mpc85xx/T104xRDB: Remove vbank check redundant code

[York Sun]

On 05/17/2015 11:31 PM, Priyanka Jain wrote:
> sw variable in checkboard function is storing vbank value
> which can only take 4-bit value.
> So check of sw value for if greater than 7 is redundant.
> 
> Signed-off-by: Priyanka Jain <Priyanka.Jain at freescale.com>
> ---
>  board/freescale/t104xrdb/t104xrdb.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/board/freescale/t104xrdb/t104xrdb.c b/board/freescale/t104xrdb/t104xrdb.c
> index 9cd5e15..c34eea6 100644
> --- a/board/freescale/t104xrdb/t104xrdb.c
> +++ b/board/freescale/t104xrdb/t104xrdb.c
> @@ -35,10 +35,7 @@ int checkboard(void)
>  	sw = CPLD_READ(flash_ctl_status);
>  	sw = ((sw & CPLD_LBMAP_MASK) >> CPLD_LBMAP_SHIFT);
>  
> -	if (sw <= 7)
> -		printf("vBank: %d\n", sw);
> -	else
> -		printf("Unsupported Bank=%x\n", sw);
> +	printf("vBank: %d\n", sw);
>  
>  	return 0;
>  }
> 

Priyanka,

4-bit variable can still have value bigger than 7. Is there other reason you
want to remove it?

York