[U-Boot] [PATCH 12/55] exynos: dts: Add PMIC and regulator definitions

Simon Glass sjg at chromium.org
Tue Jul 28 01:29:29 CEST 2015


Hi Przemyslaw,

On 10 July 2015 at 05:51, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
> Hello Simon,
>
> On 07/03/2015 02:15 AM, Simon Glass wrote:
>>
>> Snow and smdk5250 use a max77686 PMIC. We have a driver for this, so add
>> the relevant node to the device tree so it can be used.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>   arch/arm/dts/exynos5250-smdk5250.dts | 150
>> ++++++++++++++++++++++++++++++++++
>>   arch/arm/dts/exynos5250-snow.dts     | 154
>> +++++++++++++++++++++++++++++++++++
>>   2 files changed, 304 insertions(+)
>>
>> diff --git a/arch/arm/dts/exynos5250-smdk5250.dts
>> b/arch/arm/dts/exynos5250-smdk5250.dts
>> index 636fec9..8b69544 100644
>> --- a/arch/arm/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/dts/exynos5250-smdk5250.dts
>> @@ -150,3 +150,153 @@
>>                 samsung,vbus-gpio = <&gpx2 6 GPIO_ACTIVE_HIGH>;
>>         };
>>   };
>> +
>> +&i2c_0 {
>> +       status = "okay";
>> +       samsung,i2c-sda-delay = <100>;
>> +       samsung,i2c-max-bus-freq = <20000>;
>> +
>> +       max77686 at 09 {
>> +               compatible = "maxim,max77686";
>> +               reg = <0x09>;
>
>
> Are those two properties below, required? (The same for snow dts)
>
>> +               interrupt-parent = <&gpx3>;
>> +               interrupts = <2 IRQ_TYPE_NONE>;

No they are not used in U-Boot. I think it is reasonable to have them
here to match the kernel. It doesn't add a lot of space.

>> +
>> +               voltage-regulators {
>> +                       ldo1_reg: LDO1 {
>> +                               regulator-name = "P1.0V_LDO_OUT1";
>> +                               regulator-min-microvolt = <1000000>;
>> +                               regulator-max-microvolt = <1000000>;
>> +                               regulator-always-on;
>> +                       };
>
>
> ...snip...
>
> Acked-by: Przemyslaw Marczak <p.marczak at samsung.com>
>
> Best regards
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marczak at samsung.com

Applied to u-boot-dm.

Regards,
Simon


More information about the U-Boot mailing list