[U-Boot] [PATCH v4 0/2] ARM: mx5: add support for USB armory board

[Chris Kuethe]

On Thu, Mar 26, 2015 at 4:49 AM,  <andrej at inversepath.com> wrote:
> From: Andrej Rosano <andrej at inversepath.com>
>
> Hello,
>
> this series adds support for USB armory board. The patches are
> prepared against imx tree as it uses the new arch/board approach.
>
> The first patch add introduces the arch/board approach for mx5,
> as already done for mx6.

Yep, that works.

> The second patch adds basic support for USB armory board and
> is an updated version (v4) with the modifications described bellow.

If I test this against HEAD as of
f643d9294f45487f22e8f33d6572530f17eff4e9, I get an error reated to
IMX_CONFIG.

"board/inversepath/usbarmory/Kconfig:3:warning: config symbol defined
without type"

Here's a diff to fix that

diff --git a/board/inversepath/usbarmory/Kconfig
b/board/inversepath/usbarmory/Kconfig
index c2cd544..4776b1d 100644
--- a/board/inversepath/usbarmory/Kconfig
+++ b/board/inversepath/usbarmory/Kconfig
@@ -1,8 +1,5 @@
 if TARGET_USBARMORY

-config IMX_CONFIG
-    default "board/inversepath/usbarmory/imximage.cfg"
-
 config SYS_BOARD
     default "usbarmory"

diff --git a/configs/usbarmory_defconfig b/configs/usbarmory_defconfig
index 10bdd9e..237b1ca 100644
--- a/configs/usbarmory_defconfig
+++ b/configs/usbarmory_defconfig
@@ -1,3 +1,4 @@
 CONFIG_ARM=y
 CONFIG_ARCH_MX5=y
 CONFIG_TARGET_USBARMORY=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/inversepath/usbarmory/imximage.cfg"


> Changes for v4:
>  - Remove ifdef for CONFIG_FSL_ESDHC as it must always be present
>  - Remove explicit GPIO input setup (all GPIO are input after reset)
>  - Remove dummy board_late_init() and CONFIG_BOARD_LATE_INIT
>  - Remove CONFIG_BOOTARGS
>  - Fix compiling errors due to config_distro_bootcmd.h inclusion position

Tested-by: Chris Kuethe <chris.kuethe at gmail.com>

> Changes for v3:
>  - Add config_distro support
>
> Changes for v2:
>  - Fix double print_cpuinfo() call
>  - Fix CONFIG_BOOTCOMMAND typo
>  - Fix CONFIG_SYS_FSL_ESDHC_NUM to 1
>
> Andrej Rosano (2):
>   ARM: mx5: move to a standard arch/board approach
>   ARM: mx5: add support for USB armory board
>
>
> Andrej Rosano (2):
>   ARM: mx5: move to a standard arch/board approach
>   ARM: mx5: add support for USB armory board



-- 
GDB has a 'break' feature; why doesn't it have 'fix' too?