[U-Boot] [PATCH 2/3] net: Remove all references to CONFIG_ETHADDR and friends

Joe Hershberger joe.hershberger at gmail.com
Tue May 5 19:34:11 CEST 2015


Hi Albert,

On Tue, May 5, 2015 at 2:17 AM, Albert ARIBAUD <albert.aribaud at 3adev.fr> wrote:
> Bonjour Simon,
>
> Le Mon, 4 May 2015 15:37:22 -0600, Simon Glass <sjg at chromium.org> a
> écrit :
>
>> On 4 May 2015 at 13:55, Joe Hershberger <joe.hershberger at ni.com> wrote:
>> > We really don't want boards defining fixed MAC addresses in their config
>> > so we just remove the option to set it in a fixed way. If you must have
>> > a MAC address that was not provisioned, then use the random MAC address
>> > functionality.
>> >
>> > Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>> > ---
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> As much as I support the idea that one should not hard-code MAC
> addresses, I also support the idea that changes should not break
> previous behavior.

What is broken?

> And regarding the WORK board which I submitted, its configuration
> header file had this address encoded in the in-house U-Boot which
> the customer was using before; removing this address might lead to
> the customer provisioning scripts failing.

Please give details about these scripts? Where are they in the source
tree so I can make sure they still work?

Thanks,
-Joe


More information about the U-Boot mailing list