[U-Boot] [PATCH 2/3] net: Remove all references to CONFIG_ETHADDR and friends

Tom Rini trini at konsulko.com
Wed May 6 15:30:48 CEST 2015


On Tue, May 05, 2015 at 09:17:33AM +0200, Albert ARIBAUD wrote:
> Bonjour Simon,
> 
> Le Mon, 4 May 2015 15:37:22 -0600, Simon Glass <sjg at chromium.org> a
> écrit :
> 
> > On 4 May 2015 at 13:55, Joe Hershberger <joe.hershberger at ni.com> wrote:
> > > We really don't want boards defining fixed MAC addresses in their config
> > > so we just remove the option to set it in a fixed way. If you must have
> > > a MAC address that was not provisioned, then use the random MAC address
> > > functionality.
> > >
> > > Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> > > ---
> > 
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> As much as I support the idea that one should not hard-code MAC
> addresses, I also support the idea that changes should not break
> previous behavior.
> 
> And regarding the WORK board which I submitted, its configuration
> header file had this address encoded in the in-house U-Boot which
> the customer was using before; removing this address might lead to
> the customer provisioning scripts failing.

Wait, no.  The policy for a long long time has been that you don't
hard-code mac addresses into the environment, at least in mainline.
"Factory" programming or provisioning or whatever it wants to be called
always ends up needing to do something crazy.  I'm all in favor of
documenting best practices and maybe even non-default configurations
that show how to do this, but the normal build for a given board needs
to be otherwise sane.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150506/9597e861/attachment.sig>


More information about the U-Boot mailing list