[U-Boot] [PATCH 10/19] imx: ventana: fix pcie reset for GW522x

Stefano Babic sbabic at denx.de
Mon May 11 09:59:00 CEST 2015


Hi Tim,

On 09/05/2015 03:28, Tim Harvey wrote:
> The re-assignment of pcie_rst gpio for GW522x needs to occur earlier, before
> the PCI subsystem calls the toggle funciton.
> 
> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> ---
>  board/gateworks/gw_ventana/gw_ventana.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c
> index 554cd84..8cfc1f2 100644
> --- a/board/gateworks/gw_ventana/gw_ventana.c
> +++ b/board/gateworks/gw_ventana/gw_ventana.c
> @@ -1184,10 +1184,6 @@ static void setup_board_gpio(int board)
>  	}
>  
>  #if !defined(CONFIG_CMD_PCI)
> -	/* GW522x Uses GPIO3_IO23 for PCIE_RST# */
> -	if (board_type == GW52xx && info->model[4] == '2')
> -		gpio_cfg[board].pcie_rst = IMX_GPIO_NR(3, 23);
> -

This code runs now without #ifdef protection. Is it desired ?

>  	/* assert PCI_RST# (released by OS when clock is valid) */
>  	gpio_request(gpio_cfg[board].pcie_rst, "pci_rst#");
>  	gpio_direction_output(gpio_cfg[board].pcie_rst, 0);
> @@ -1435,6 +1431,10 @@ int board_init(void)
>  		int count = gpio_cfg[board_type].num_pads;
>  
>  		imx_iomux_v3_setup_multiple_pads(p, count);
> +
> +		/* GW522x Uses GPIO3_IO23 for PCIE_RST# */
> +		if (board_type == GW52xx && ventana_info.model[4] == '2')
> +			gpio_cfg[board_type].pcie_rst = IMX_GPIO_NR(3, 23);
>  	}
>  
>  	return 0;
> 

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list