[U-Boot] [PATCH 08/19] imx: ventana: config: use MMC SPL RAW support

Stefano Babic sbabic at denx.de
Fri May 15 16:20:12 CEST 2015


Hi Tim,

On 13/05/2015 01:23, Tim Harvey wrote:
> On Fri, May 8, 2015 at 6:36 PM, Fabio Estevam <festevam at gmail.com> wrote:
>> Hi Tim,
>>
>> On Fri, May 8, 2015 at 10:28 PM, Tim Harvey <tharvey at gateworks.com> wrote:
>>> Switch to MMC RAW support for SPL. We will place the uboot.img at 69KB.
>>>
>>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
>>> ---
>>>  include/configs/gw_ventana.h | 6 ++----
>>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
>>> index 63af20c..e18e262 100644
>>> --- a/include/configs/gw_ventana.h
>>> +++ b/include/configs/gw_ventana.h
>>> @@ -11,10 +11,8 @@
>>>  #define CONFIG_SPL_BOARD_INIT
>>>  #define CONFIG_SPL_NAND_SUPPORT
>>>  #define CONFIG_SPL_MMC_SUPPORT
>>> -#define CONFIG_SPL_FAT_SUPPORT
>>> -/*
>>> -#define CONFIG_SPL_SATA_SUPPORT
>>> -*/
>>> +/* Location on MMC to read U-Boot from */
>>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 138 /* 69KB */
>>
>> No need to define this as it is the default from imx6_spl.h
> 
> Fabio,
> 
> Thanks for pointing that out - I'll remove it.
> 

Then rework the commit message, pointing to the remove of SPL_FAT and
SPL_SATA.

I like that your patchset is fully orthogonal - rewieving is easier and
I do not miss your changes - thanks for that !

For that reason, I am applying most of your patches - you do not need to
post the whole patchset again. Due to rework in this one, I would like
you repost in a new patchset only these ones:

imx: ventana: config: use MMC SPL RAW support (this one)
imx: ventana: (cosmetic) clean up size defines for improved readability
imx: ventana: add pmic_setup to SPL
imx: ventana: config: enable Falcon mode

I am merging the rest of your patches

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list