[U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h

[Soeren Moch]

On 05/26/15 13:39, Stefano Babic wrote:
> Hi Soeren,
>
> On 22/05/2015 20:18, Soeren Moch wrote:
>>> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO,
>>> CONFIG_DISPLAY_CPUINFO
>>> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common
>>>
>>> Signed-off-by: Peter Robinson<pbrobinson at gmail.com>
>>> Reviewed-by: Tom Rini <trini at konsulko.com>
>>
>> Some boards defineCONFIG_DISPLAY_BOARDINFO_LATE (instead of
>> CONFIG_DISPLAY_BOARDINFO) to also see this info on HDMI.
>>
>> So please add CONFIG_DISPLAY_BOARDINFO_LATE to mx6_common.h
>>
>> Sorry, I missed this in the last review round.
>
> As far as I can see, there are only two boards : gw_ventana and tbs2910.
> CONFIG_DISPLAY_BOARDINFO_LATE enables show_board_info(), and this is not
> weak, printing twice if we have both CONFIG_DISPLAY_BOARDINFO_LATE and
> CONFIG_DISPLAY_BOARDINFO. I would suggest that we add
> 	#undef CONFIG_DISPLAY_BOARDINFO
> 	#define CONFIG_DISPLAY_BOARDINFO_LATE
>
> to gw_ventana.h and tbs2910.h after applying this series.


Stefano,

OK, fine with me.

It is unfortunate that there is no CONFIG_DISPLAY_CPUINFO_LATE.
The real solution would be to print both board and cpu info
after enabling the HDMI frame buffer. BOARDINFO_LATE alone
is not that important. So I agree to apply this patch series
without another fix.

Maybe we should add
#ifndef CONFIG_DISPLAY_BOARDINFO_LATE
#define CONFIG_DISPLAY_BOARDINFO
#endif
to mx6_common.h later. There are already other conditional defines
in there, and that could save the #undef in individual board files.
And, of course, you are right, printing the board info twice (in
serial output) can also be confusing.

Regards,
Soeren