[U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h

Soeren Moch smoch at web.de
Fri May 29 20:02:11 CEST 2015


Stefano,
>> As far as I can see, there are only two boards : gw_ventana and tbs2910.
>> CONFIG_DISPLAY_BOARDINFO_LATE enables show_board_info(), and this is not
>> weak, printing twice if we have both CONFIG_DISPLAY_BOARDINFO_LATE and
>> CONFIG_DISPLAY_BOARDINFO. I would suggest that we add
>>     #undef CONFIG_DISPLAY_BOARDINFO
>>     #define CONFIG_DISPLAY_BOARDINFO_LATE
>>
>> to gw_ventana.h and tbs2910.h after applying this series.
>
>
> It is unfortunate that there is no CONFIG_DISPLAY_CPUINFO_LATE.
> The real solution would be to print both board and cpu info
> after enabling the HDMI frame buffer. BOARDINFO_LATE alone
> is not that important. So I agree to apply this patch series
> without another fix.
>
> Maybe we should add
> #ifndef CONFIG_DISPLAY_BOARDINFO_LATE
> #define CONFIG_DISPLAY_BOARDINFO
> #endif
> to mx6_common.h later. There are already other conditional defines
> in there, and that could save the #undef in individual board files.

I will add a PRE_CONSOLE_BUFFER to tbs2910.h , so there is no
need anymore to add CONFIG_DISPLAY_BOARDINFO_LATE.

I'm fine with the merged consolidation series, no further action required
on this topic from my side.

Regards,
Soeren



More information about the U-Boot mailing list