[U-Boot] [PATCH 2/2] usb: eth: add Realtek RTL8152B/RTL8153 driver

[Stephen Warren]

On 11/20/2015 09:10 PM, Anand Moon wrote:
...
> ​I have just patch the driver and enable the driver.
...
> After doing 'usb start' and 'usb reset'
> 
> I have tested with ASIX88179 USB 3.0 Ethernet cable and the u-boot
> successfully detected the device.
> My fried also tested with RTL8152 USB 3.0 Ethernet cable and the u-boot
> successfully detected the device.
> But with this driver I am not able to detect the Ethernet USB3.0 RT8153-VB
> connected to the OdroidXU4 board.
...
> ​U-Boot 2015.10-25167-g439fcb9-dirty (Nov 21 2015 - 14:27:19 +1030) for
> ODROID-XU3
...
> ODROID-XU3 # usb start
...
> USB Ethernet device detected: 0xbda:0x8153
> Endpoints In 1 Out 2 Int 3
> Setup ERROR: address device command for slot 1.
> Unknown version 0x7cf0
> Unknown Device
> 0 Ethernet Device(s) found

Ted sent an off-list patch that might be related to this. Perhaps EHCI
has the same check? Try something like the following:

> From 0aca6ac3391a3579815dd06ad981c2c7de0d59f7 Mon Sep 17 00:00:00 2001
> From: Ted Chen <tedchen at realtek.com>
> Date: Fri, 20 Nov 2015 18:09:20 +0800
> Subject: [PATCH] usb: xhci: Fix vendor command error if the request type is
>  USB_REQ_SET_ADDRESS or USB_REQ_SET_CONFIGURATION.
> 
> Add a condition of set_address and set_configuration to check
> if the request is standardized.
> 
> Signed-off-by: Ted Chen <tedchen at realtek.com>
> ---
>  drivers/usb/host/xhci.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index ca598aa..cb8a04b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -941,10 +941,12 @@ static int _xhci_submit_control_msg(struct usb_device *udev, unsigned long pipe,
>  	if (usb_pipedevice(pipe) == ctrl->rootdev)
>  		return xhci_submit_root(udev, pipe, buffer, setup);
>  
> -	if (setup->request == USB_REQ_SET_ADDRESS)
> +	if (setup->request == USB_REQ_SET_ADDRESS &&
> +	   (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD)
>  		return xhci_address_device(udev, root_portnr);
>  
> -	if (setup->request == USB_REQ_SET_CONFIGURATION) {
> +	if (setup->request == USB_REQ_SET_CONFIGURATION &&
> +	   (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD) {
>  		ret = xhci_set_configuration(udev);
>  		if (ret) {
>  			puts("Failed to configure xHCI endpoint\n");
> -- 
> 1.7.9.5