[U-Boot] [PATCH 2/2] usb: eth: add Realtek RTL8152B/RTL8153 driver

[Anand Moon]

Hi Stephen/Ted

On 22 November 2015 at 22:42, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 11/20/2015 09:10 PM, Anand Moon wrote:
> ...
>> I have just patch the driver and enable the driver.
> ...
>> After doing 'usb start' and 'usb reset'
>>
>> I have tested with ASIX88179 USB 3.0 Ethernet cable and the u-boot
>> successfully detected the device.
>> My fried also tested with RTL8152 USB 3.0 Ethernet cable and the u-boot
>> successfully detected the device.
>> But with this driver I am not able to detect the Ethernet USB3.0 RT8153-VB
>> connected to the OdroidXU4 board.
> ...
>> U-Boot 2015.10-25167-g439fcb9-dirty (Nov 21 2015 - 14:27:19 +1030) for
>> ODROID-XU3
> ...
>> ODROID-XU3 # usb start
> ...
>> USB Ethernet device detected: 0xbda:0x8153
>> Endpoints In 1 Out 2 Int 3
>> Setup ERROR: address device command for slot 1.
>> Unknown version 0x7cf0
>> Unknown Device
>> 0 Ethernet Device(s) found
>
> Ted sent an off-list patch that might be related to this. Perhaps EHCI
> has the same check? Try something like the following:
>
>> From 0aca6ac3391a3579815dd06ad981c2c7de0d59f7 Mon Sep 17 00:00:00 2001
>> From: Ted Chen <tedchen at realtek.com>
>> Date: Fri, 20 Nov 2015 18:09:20 +0800
>> Subject: [PATCH] usb: xhci: Fix vendor command error if the request type is
>>  USB_REQ_SET_ADDRESS or USB_REQ_SET_CONFIGURATION.
>>
>> Add a condition of set_address and set_configuration to check
>> if the request is standardized.
>>
>> Signed-off-by: Ted Chen <tedchen at realtek.com>
>> ---
>>  drivers/usb/host/xhci.c |    6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index ca598aa..cb8a04b 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -941,10 +941,12 @@ static int _xhci_submit_control_msg(struct usb_device *udev, unsigned long pipe,
>>       if (usb_pipedevice(pipe) == ctrl->rootdev)
>>               return xhci_submit_root(udev, pipe, buffer, setup);
>>
>> -     if (setup->request == USB_REQ_SET_ADDRESS)
>> +     if (setup->request == USB_REQ_SET_ADDRESS &&
>> +        (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD)
>>               return xhci_address_device(udev, root_portnr);
>>
>> -     if (setup->request == USB_REQ_SET_CONFIGURATION) {
>> +     if (setup->request == USB_REQ_SET_CONFIGURATION &&
>> +        (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD) {
>>               ret = xhci_set_configuration(udev);
>>               if (ret) {
>>                       puts("Failed to configure xHCI endpoint\n");
>> --
>> 1.7.9.5
>

Thanks for this patch. Now it seem to be working fine.
-----------------------------------------------------------------------
U-Boot 2015.10-25167-g439fcb9-dirty (Nov 23 2015 - 05:46:45 +1030) for
ODROID-XU3

CPU:   Exynos5422 @ 800 MHz
Model: Odroid XU3 based on EXYNOS5422
Board: Odroid XU3 based on EXYNOS5422
Type:  xu4
DRAM:  2 GiB
__of_translate_address: Bad cell count for gpx0
MMC:   EXYNOS DWMMC: 0, EXYNOS DWMMC: 1
*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Net:   No ethernet found.
Hit any key to stop autoboot:  0
ODROID-XU3 #
ODROID-XU3 # usb start
starting USB...
USB0:   USB EHCI 1.00
USB1:   Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.00
USB2:   Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
scanning bus 1 for devices... 2 USB Device(s) found
scanning bus 2 for devices... 2 USB Device(s) found
       scanning usb for ethernet devices...
Warning: r8152#0 using MAC address from net device
MAC 00:1e:06:31:06:b3
1 Ethernet Device(s) found
ODROID-XU3 #
ODROID-XU3 #
ODROID-XU3 # dhcp
BOOTP broadcast 1
DHCP client bound to address 10.0.0.114 (5 ms)
*** Warning: no boot file name; using '0A000072.img'
Using r8152#0 device
TFTP from server 0.0.0.0; our IP address is 10.0.0.114; sending
through gateway 10.0.0.1
Filename '0A000072.img'.
Load address: 0x43e00000
Loading: *
TFTP error: 'File not found' (1)
Not retrying...
ODROID-XU3 # setenv serverip 10.0.0.102
ODROID-XU3 #  tftpboot 40080000 zImage
Using r8152#0 device
TFTP from server 10.0.0.102; our IP address is 10.0.0.114
Filename 'zImage'.
Load address: 0x40080000
Loading: #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         ##############################################
         949.2 KiB/s
done
Bytes transferred = 3229744 (314830 hex)
ODROID-XU3 #
-----------------------------------------------------------------------
Thank you very much. :)

-Anand Moon