[U-Boot] [PATCH] pci: Fix expansion ROM programming for multi-function devices
Simon Glass
sjg at chromium.org
Mon Oct 19 04:18:04 CEST 2015
On 8 October 2015 at 18:30, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Fri, Oct 9, 2015 at 2:10 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Bin,
>>
>> On 8 October 2015 at 19:07, Simon Glass <sjg at chromium.org> wrote:
>>> On 7 October 2015 at 10:13, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> PCI_HEADER_TYPE register (offset 0x0e) bit 7 is an indicator
>>>> for multi-function devices. We should mask it off before using
>>>> it as the header type.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>>> ---
>>>>
>>>> drivers/pci/pci_auto.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>> Acked-by: Simon Glass <sjg at chromium.org>
>>
>> I'm not sure if this fix actually fixes anything for existing boards,
>> but I'll pick it up.
>>
>
> Yes, it fixes the Crown Bay board where Topcliff PCI device D0:F0 is a
> multi-function device and has a ROM.
>
>> Is there anything else I have missed?
>>
>
> So far I believe everything for this release is in. Thanks!
>
> Regards,
> Bin
Applied to u-boot-x86, and now in mainline.
More information about the U-Boot
mailing list