[U-Boot] [PATCH v3] Tegra: T210: Add QSPI driver

[Tom Warren]

Stephen,

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org] 
Sent: Wednesday, October 21, 2015 9:52 AM
To: Tom Warren <TWarren at nvidia.com>
Cc: u-boot at lists.denx.de; jteki at openedev.com; Stephen Warren <swarren at nvidia.com>; tomcwarren3959 at gmail.com
Subject: Re: [U-Boot] [PATCH v3] Tegra: T210: Add QSPI driver

On 10/20/2015 03:31 PM, Tom Warren wrote:
> This is the normal Tegra SPI driver modified to work with the QSPI 
> controller in Tegra210. It does not do 2x/4x transfers or any other 
> QSPI protocol.
>
> Author: Yen Lin <yelin at nvidia.com>
> Signed-off-by: Yen Lin <yelin at nvidia.com>
> Signed-off-by: Tom Warren <twarren at nvidia.com>
> ---
> Changes in v2:
> - Drop defconfig and pinmux files, this is a driver-only patch.
> - If/when pinmux tables have been updated for P2371/P2571, another
> - patch will be sent to enable the QSPI driver on those boards.
> Changes in v3:
> - removed status reg write/clear in claim_bus(), done in xfer()

The code looks OK, but we need the binding document written and approved before we commit to the driver, I think.
OK. As I asked in the V2 review comments, are you going to write the binding doc, or if not, who do you think should/could do it? I don't know enough to attempt it.

Thanks,

Tom
--
nvpublic