[U-Boot] [PATCH v3] Tegra: T210: Add QSPI driver

Stephen Warren swarren at wwwdotorg.org
Wed Oct 21 19:18:41 CEST 2015


On 10/21/2015 10:58 AM, Tom Warren wrote:
>Stephen Warren wrote atWednesday, October 21, 2015 9:52 AM:
>> On 10/20/2015 03:31 PM, Tom Warren wrote:
>>> This is the normal Tegra SPI driver modified to work with the QSPI
>>> controller in Tegra210. It does not do 2x/4x transfers or any other
>>> QSPI protocol.
>>>
>>> Author: Yen Lin <yelin at nvidia.com>
>>> Signed-off-by: Yen Lin <yelin at nvidia.com>
>>> Signed-off-by: Tom Warren <twarren at nvidia.com>
>>> ---
>>> Changes in v2:
>>> - Drop defconfig and pinmux files, this is a driver-only patch.
>>> - If/when pinmux tables have been updated for P2371/P2571, another
>>> - patch will be sent to enable the QSPI driver on those boards.
>>> Changes in v3:
>>> - removed status reg write/clear in claim_bus(), done in xfer()
>>
>> The code looks OK, but we need the binding document written and approved before we commit to the driver, I think.
 >
> OK. As I asked in the V2 review comments, are you going to write the binding doc, or if not, who do you think should/could do it? I don't know enough to attempt it.

Sorry, I didn't notice that comment in your email, since the quoting 
style wasn't standard (indent with >).

It's the responsibility of the person who implements the driver for the 
device. Writing binding docs is now unfortunately part and parcel of 
almost any driver work.

This device is probably similar enough to the other Tegra SPI 
controllers that you can likely cut/paste most of the doc, and simply 
adjust the names and resource definitions as appropriate for this HW module.


More information about the U-Boot mailing list