[U-Boot] [PATCH] arm: atmel: Add SAMA5D2 Xplained board

[Yang, Wenyou]

Hi Andreas,

> > -----Original Message-----
> > From: Andreas Bießmann [mailto:andreas.devel at googlemail.com]
> > Sent: 2015年10月24日 6:42
> > To: Yang, Wenyou; U-Boot Mailing List
> > Subject: Re: [PATCH] arm: atmel: Add SAMA5D2 Xplained board
> >
> > Dear Wenyou Yang,
> >
> > On 22.09.15 09:59, Wenyou Yang wrote:
> > > The board supports following features:
> > >  - Boot media support: SD card/e.MMC/SPI flash,
> > >  - Support LCD display (optional, disabled by default),
> > >  - Support ethernet,
> > >  - Support USB mass storage.
> > >
> > > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> > > ---

... ....

> > > +
> > > +int board_eth_init(bd_t *bis)
> > > +{
> > > +	int rc = 0;
> > > +
> > > +#ifdef CONFIG_MACB
> > > +	rc = macb_eth_initialize(0, (void *)ATMEL_BASE_GMAC, 0x00); #endif
> > > +
> > > +#ifdef CONFIG_USB_GADGET_ATMEL_USBA
> > > +	usba_udc_probe(&pdata);
> > > +#ifdef CONFIG_USB_ETH_RNDIS
> > > +	usb_eth_initialize(bis);
> > > +#endif
> > > +#endif
> >
> > How about the rc with USB gadget but no GMAC?
Both usba_udc_probe() and usb_eth_initialize() always return 0,  
So I think the rc should not be assigned by the their returns again.
If not, they probably override the failure return value (that is, negative value) from GMAC.


Best Regards,
Wenyou Yang