[U-Boot] [PATCH v4 4/6] cgtqmx6eval: Add SPL support

[Otavio Salvador]

On Thu, Oct 29, 2015 at 8:53 AM, Stefano Babic <sbabic at denx.de> wrote:
> Hi Otavio,
>
> On 29/10/2015 11:32, Otavio Salvador wrote:
>> Congatec has several MX6 boards based on quad, dual, dual-lite and solo.
>>
>> Add SPL support so that all the variants can be supported.
>>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
...
>> --- a/board/congatec/cgtqmx6eval/README
>> +++ b/board/congatec/cgtqmx6eval/README
...
>> +=> sf update 0x12000000 0x400 0x10000
>> +
>> +=> tftp u-boot.img
>
> Just a nitpick. This assumes that loadaddr is set to 0x12000000, as it
> is in mx6_common.h. If value changes, it is not strictly correct. Maybe
> to avoid confusion, you can write "tftp 0x12000000 SPL" (explicitely
> address it) or you change sf update to use the loadaddr variable as "sf
> update ${loadaddr} 0x400 0x10000"

Can you replace it with ${loadaddr} when applying or do you want a new
patch revision?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750