[U-Boot] [PATCH v2 7/8] zynq: Move SPL console init out of board_init_f()

Michal Simek monstr at monstr.eu
Tue Sep 1 10:44:23 CEST 2015


On 08/28/2015 10:50 PM, Simon Glass wrote:
> We should not init the console this early and there is no need to. If we want
> to do early init it can be done in spl_board_init(). Move the
> preloader_console_init() call from board_init_f() to board_init_r().
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Tested-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/mach-zynq/spl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-zynq/spl.c b/arch/arm/mach-zynq/spl.c
> index e7df6d3..7bdac3b 100644
> --- a/arch/arm/mach-zynq/spl.c
> +++ b/arch/arm/mach-zynq/spl.c
> @@ -20,7 +20,6 @@ void board_init_f(ulong dummy)
>  	/* Clear the BSS. */
>  	memset(__bss_start, 0, __bss_end - __bss_start);
>  
> -	preloader_console_init();
>  	arch_cpu_init();
>  	board_init_r(NULL, 0);
>  }
> @@ -28,6 +27,7 @@ void board_init_f(ulong dummy)
>  #ifdef CONFIG_SPL_BOARD_INIT
>  void spl_board_init(void)
>  {
> +	preloader_console_init();
>  	board_init();
>  }
>  #endif
> 

Tested-by: Michal Simek <michal.simek at xilinx.com>

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150901/1ec9b138/attachment.sig>


More information about the U-Boot mailing list