[U-Boot] [PATCH 13/13] imx: mx7dsabresd: Add support for MX7D SABRESD board

[Fabio Estevam]

On Tue, Sep 1, 2015 at 1:22 PM, Adrian Alonso <aalonso at freescale.com> wrote:

> + * Boot Device : one of
> + * spi/sd/nand/onenand, qspi/nor
> + */
> +
> +#ifdef CONFIG_SYS_BOOT_QSPI

This config option does not exist in mainline. Please remove it.

> +BOOT_FROM      qspi
> +#elif defined(CONFIG_SYS_BOOT_EIMNOR)

Ditto.

> +BOOT_FROM      nor
> +#else
> +BOOT_FROM      sd
> +#endif
> +
> +#ifdef CONFIG_SECURE_BOOT
> +CSF CONFIG_CSF_SIZE

Ditto.

> +static int mmc_get_env_devno(void)
> +{
> +       struct bootrom_sw_info **p =
> +               (struct bootrom_sw_info **)ROM_SW_INFO_ADDR;
> +
> +       u8 boot_type = (*p)->boot_dev_type;
> +       u8 dev_no = (*p)->boot_dev_instance;
> +
> +       /* If not boot from sd/mmc, use default value */
> +       if ((boot_type != BOOT_TYPE_SD) && (boot_type != BOOT_TYPE_MMC))
> +               return CONFIG_SYS_MMC_ENV_DEV;
> +
> +       if (2 == dev_no)

dev_no == 2 looks better.

> +               dev_no--;
> +
> +       return dev_no;
> +}
> +
> +static int mmc_map_to_kernel_blk(int dev_no)
> +{
> +       if (1 == dev_no)

Same here.