[U-Boot] [PATCH 3/3] omap3: cm-t3517: change environment size

Igor Grinberg grinberg at compulab.co.il
Tue Sep 8 10:48:58 CEST 2015


Hi Dima,

On 09/08/15 09:50, Dmitry Lifshitz wrote:
> Mainline CM-T3517 U-Boot environment size differs from the that one
> shipped with CM-T3517 boards.

There is some strangeness in the above sentence...

> 
> Update environment size, to avoid backward compatability issues.

s/compatability/compatibility/

> 
> Signed-off-by: Dmitry Lifshitz <lifshitz at compulab.co.il>
> ---
>  include/configs/cm_t3517.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h
> index 2d16799..36488d7 100644
> --- a/include/configs/cm_t3517.h
> +++ b/include/configs/cm_t3517.h
> @@ -66,8 +66,8 @@
>  /*
>   * Size of malloc() pool
>   */
> -#define CONFIG_ENV_SIZE		(16 << 10)	/* 16 KiB */
> -#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + (128 << 10))
> +#define CONFIG_ENV_SIZE		(128 << 10)	/* 128 KiB */
> +#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + (512 << 10))

Why do you change CONFIG_SYS_MALLOC_LEN?
Isn't it not enough?
If so, I would expect to see some explanation in the commit message.


-- 
Regards,
Igor.


More information about the U-Boot mailing list