[U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place

Jagan Teki jteki at openedev.com
Tue Sep 8 14:21:36 CEST 2015


On 8 September 2015 at 06:48, Chin Liang See <clsee at altera.com> wrote:
> Ensure the intended SCLK frequency not exceeding the maximum
> frequency. If that happen, SCLK will set to maximum frequency.
>
> Signed-off-by: Chin Liang See <clsee at altera.com>
> Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux at gmail.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Vikas Manocha <vikas.manocha at st.com>
> Cc: Jagannadh Teki <jteki at openedev.com>
> Cc: Pavel Machek <pavel at denx.de>
> ---
>  drivers/spi/cadence_qspi.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
> index 8c0f7dd..f430b5d 100644
> --- a/drivers/spi/cadence_qspi.c
> +++ b/drivers/spi/cadence_qspi.c
> @@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
>         struct cadence_spi_priv *priv = dev_get_priv(bus);
>         int err;
>
> +       if (hz > plat->max_hz) {
> +               hz = plat->max_hz;
> +               puts("SF: Default to maximum supported SCLK frequency\n");

This print mayn't require just assign plat->max_hz enough.

Reviewed-by: Jagan Teki <jteki at openedev.com>

> +       }
> +
>         /* Disable QSPI */
>         cadence_qspi_apb_controller_disable(priv->regbase);

thanks!
-- 
Jagan | openedev.


More information about the U-Boot mailing list