[U-Boot] Zynq build failure

[Jagan Teki]

On 9 September 2015 at 14:25, Siva Durga Prasad Paladugu
<siva.durga.paladugu at xilinx.com> wrote:
> Hi Jagan,
>
>> -----Original Message-----
>> From: Jagan Teki [mailto:jteki at openedev.com]
>> Sent: Wednesday, September 09, 2015 12:57 PM
>> To: Siva Durga Prasad Paladugu
>> Cc: Michal Simek; u-boot at lists.denx.de
>> Subject: Re: [U-Boot] Zynq build failure
>>
>> On 9 September 2015 at 11:02, Siva Durga Prasad Paladugu
>> <siva.durga.paladugu at xilinx.com> wrote:
>> > Hi Jagan,
>> >
>> >
>> >> -----Original Message-----
>> >> From: Jagan Teki [mailto:jteki at openedev.com]
>> >> Sent: Tuesday, September 08, 2015 11:22 PM
>> >> To: Michal Simek
>> >> Cc: Siva Durga Prasad Paladugu; u-boot at lists.denx.de
>> >> Subject: Re: [U-Boot] Zynq build failure
>> >>
>> >> On 8 September 2015 at 20:06, Michal Simek <michal.simek at xilinx.com>
>> >> wrote:
>> >> > On 09/08/2015 11:48 AM, Jagan Teki wrote:
>> >> >> On 4 September 2015 at 14:22, Jagan Teki <jteki at openedev.com>
>> wrote:
>> >> >>> Hi Michal/Siva,
>> >> >>>
>> >> >>> Any fix for this failure?
>> >> >>>
>> >> >>>   CC      spl/drivers/mtd/spi/spi_spl_load.o
>> >> >>> drivers/mtd/spi/spi_spl_load.c: In function 'spi_load_image_os':
>> >> >>> drivers/mtd/spi/spi_spl_load.c:26:24: error:
>> >> >>> 'CONFIG_SYS_SPI_KERNEL_OFFS' undeclared (first use in this
>> >> >>> function)
>> >> >>> drivers/mtd/spi/spi_spl_load.c:26:24: note: each undeclared
>> >> >>> identifier is reported only once for each function it appears in
>> >> >>> drivers/mtd/spi/spi_spl_load.c:38:24: error:
>> >> >>> 'CONFIG_SYS_SPI_ARGS_OFFS' undeclared (first use in this
>> >> >>> function)
>> >> >>> drivers/mtd/spi/spi_spl_load.c:39:10: error:
>> >> >>> 'CONFIG_SYS_SPI_ARGS_SIZE' undeclared (first use in this
>> >> >>> function)
>> >> >>> make[3]: *** [spl/drivers/mtd/spi/spi_spl_load.o] Error 1
>> >> >>
>> >> >> Any help?
>> >> >>
>> >> >
>> >> > It is just MTD map. It means it can be whatever. :-)
>> >> >
>> >> > Let's say - bitstream first - max 0x1100000 for 7z100 Then DTB -
>> >> > 0.5MB max and the rest kernel
>> >> >
>> >> > #define CONFIG_SYS_SPI_ARGS_OFFS 0x1100000 #define
>> >> > CONFIG_SYS_SPI_ARGS_SIZE 0x80000 #define
>> >> CONFIG_SYS_SPI_KERNEL_OFFS
>> >> > (CONFIG_SYS_SPI_ARGS_OFFS +
>> >> > CONFIG_SYS_SPI_ARGS_SIZE)
>> >> >
>> >> > Adding this to zynq-common and we are done.
>> >> > Do you want me to send the patch for it?
>> >>
>> >> Please do, I will take this as part of qspi patches.
>> > We are getting the below compilation error after defining these macros.
>> We are seeing this issue after moving to driver model. Could you please look
>> into this.
>> >
>> > In file included from drivers/mtd/spi/sf_probe.c:11:0:
>> > drivers/mtd/spi/sf_probe.c: In function 'spi_flash_std_probe':
>> > drivers/mtd/spi/sf_probe.c:636:54: error: dereferencing pointer to
>> incomplete type
>> >   debug("%s: slave=%p, cs=%d\n", __func__, slave, plat->cs);
>> >                                                       ^
>> > include/common.h:109:26: note: in definition of macro 'debug_cond'
>> >     printf(pr_fmt(fmt), ##args); \
>> >                           ^
>> > drivers/mtd/spi/sf_probe.c:636:2: note: in expansion of macro 'debug'
>> >   debug("%s: slave=%p, cs=%d\n", __func__, slave, plat->cs);
>> >   ^
>> > make[2]: *** [spl/drivers/mtd/spi/sf_probe.o] Error 1
>> > make[2]: *** Waiting for unfinished jobs....
>> >   CC      spl/common/command.o
>> >   CC      spl/common/s_record.o
>> > make[1]: *** [spl/drivers/mtd/spi] Error 2
>> > make[1]: *** Waiting for unfinished jobs....
>>
>> Probably you might pull, different branch - take u-boot-spi/master.
> I Just got it, To make it working we should have these macros defined in config file and also there are some changes which are required to
> Support DM in SPL for these compilation failures. Simon already has those patches in dm tree.
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working

OK, please send the missing config patch - anyway this should require
even for Simon SPL changes.

thanks!
-- 
Jagan.