[U-Boot] [RESEND PATCH v3 0/5] fix NetConsole for CONFIG_DM_ETH
Bernhard Nortmann
bernhard.nortmann at web.de
Mon Sep 14 15:29:42 CEST 2015
(I'm resending this as patch 1/5 is still requiring an ACK/NAK.)
With the introduction of driver model and accompanying changes,
outdated code in netconsole.c leads to compilation errors when both
CONFIG_NETCONSOLE and CONFIG_DM_ETH are set.
This is a series of patches to fix these issues and get NetConsole
working again with DM_ETH. v2 adds some proper subsystem prefixes
on the commit messages, and enables a test case (sunxi board
configuration for Banana Pi/Pro) that combines CONFIG_DM_ETH and
CONFIG_NETCONSOLE. v3 adds some ACKs by J. Hershberger and a fix
to make proper use of dev_get_uclass_priv().
I have tested the resulting code on my Banana Pi (sun7i / Allwinner
A20) and had a functional NetConsole again. I also backported
eth_is_active() and the netconsole.c changes to v2015.04, to make
sure they properly worked in case CONFIG_DM_ETH is absent
(v2015.04 predates the introduction of DM_ETH, and I'm lacking
other hardware to test CONFIG_NETCONSOLE with).
Regards, B. Nortmann
Changes in v3:
- use dev_get_uclass_priv()
Changes in v2:
- add "net:" prefix to commit message
- add "net:" prefix to commit message
Bernhard Nortmann (5):
net: expose eth_is_active() function to test network device state
net: fix netconsole when CONFIG_DM_ETH is set
net: avoid eth_unregister() call when function is unavailable
net: support NETCONSOLE option via Kconfig
sunxi: add NetConsole by default for Banana Pi/Pro
common/bootm.c | 2 ++
configs/Bananapi_defconfig | 3 ++-
configs/Bananapro_defconfig | 3 ++-
drivers/net/netconsole.c | 14 +++++++++++---
include/net.h | 6 ++++++
net/Kconfig | 6 ++++++
net/eth.c | 18 +++++++++++++++++-
7 files changed, 46 insertions(+), 6 deletions(-)
--
2.4.6
More information about the U-Boot
mailing list