[U-Boot] [RESEND PATCH v3 1/5] net: expose eth_is_active() function to test network device state

Joe Hershberger joe.hershberger at gmail.com
Mon Sep 14 23:26:21 CEST 2015


Hi Bernhard,

On Mon, Sep 14, 2015 at 8:29 AM, Bernhard Nortmann
<bernhard.nortmann at web.de> wrote:
> The previous eth_device struct returned by eth_get_dev() allowed
> code to directly query the state member field. However, with
> CONFIG_DM_ETH this data gets encapsulated (i.e. private), and
> eth_get_dev() returns a udevice struct 'abstraction' instead.
>
> This breaks legacy code relying on the former behaviour - e.g.
> netconsole.
> (see http://lists.denx.de/pipermail/u-boot/2015-June/216528.html)
>
> The patch introduces a method to retrieve the ethernet device
> state in a 'clean' and uniform way, supporting both legacy code
> and driver model. The new function eth_is_active() accepts a
> device struct pointer and tests it for ETH_STATE_ACTIVE.
>
> Signed-off-by: Bernhard Nortmann <bernhard.nortmann at web.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list