[U-Boot] [Patch v2 02/16] common/board_f.c: modify the macro to use get_clocks() more common

[York Sun]

On 09/22/2015 08:32 AM, Scott Wood wrote:
> On Tue, 2015-09-22 at 07:49 -0700, York Sun wrote:
>> On 09/21/2015 07:59 PM, Gong Qianyu-B52263 wrote:
>>>
>>>> -----Original Message-----
>>>> From: Sun York-R58495
>>>> Sent: Tuesday, September 22, 2015 1:27 AM
>>>> To: Gong Qianyu-B52263; u-boot at lists.denx.de
>>>> Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Xie 
>>>> Shaohui-
>>>> B21989; Song Wenbin-B53747; Wood Scott-B07421
>>>> Subject: Re: [Patch v2 02/16] common/board_f.c: modify the macro to use
>>>> get_clocks() more common
>>>>
>>>>
>>>>
>>>> On 09/17/2015 12:02 AM, Gong Qianyu wrote:
>>>>> get_clocks() should not be limited by ESDHC.
>>>>>
>>>>> Signed-off-by: Gong Qianyu <Qianyu.Gong at freescale.com>
>>>>> ---
>>>>>  common/board_f.c                  | 2 +-
>>>>>  include/configs/BSC9132QDS.h      | 1 +
>>>>>  include/configs/MPC8308RDB.h      | 1 +
>>>>>  include/configs/MPC837XEMDS.h     | 1 +
>>>>>  include/configs/MPC837XERDB.h     | 1 +
>>>>>  include/configs/MPC8536DS.h       | 1 +
>>>>>  include/configs/MPC8569MDS.h      | 1 +
>>>>>  include/configs/P1010RDB.h        | 1 +
>>>>>  include/configs/P1022DS.h         | 1 +
>>>>>  include/configs/P2041RDB.h        | 1 +
>>>>>  include/configs/T102xQDS.h        | 1 +
>>>>>  include/configs/T102xRDB.h        | 1 +
>>>>>  include/configs/T1040QDS.h        | 1 +
>>>>>  include/configs/T104xRDB.h        | 1 +
>>>>>  include/configs/T208xQDS.h        | 1 +
>>>>>  include/configs/T208xRDB.h        | 1 +
>>>>>  include/configs/T4240QDS.h        | 1 +
>>>>>  include/configs/T4240RDB.h        | 1 +
>>>>>  include/configs/UCP1020.h         | 1 +
>>>>>  include/configs/colibri_vf.h      | 1 +
>>>>>  include/configs/controlcenterd.h  | 1 +
>>>>>  include/configs/corenet_ds.h      | 1 +
>>>>>  include/configs/hrcon.h           | 1 +
>>>>>  include/configs/ima3-mx53.h       | 1 +
>>>>>  include/configs/ls1021aqds.h      | 1 +
>>>>>  include/configs/ls1021atwr.h      | 1 +
>>>>>  include/configs/ls2085aqds.h      | 1 +
>>>>>  include/configs/ls2085ardb.h      | 1 +
>>>>>  include/configs/m53evk.h          | 1 +
>>>>>  include/configs/mx25pdk.h         | 1 +
>>>>>  include/configs/mx35pdk.h         | 1 +
>>>>>  include/configs/mx51_efikamx.h    | 1 +
>>>>>  include/configs/mx51evk.h         | 1 +
>>>>>  include/configs/mx53ard.h         | 1 +
>>>>>  include/configs/mx53evk.h         | 1 +
>>>>>  include/configs/mx53loco.h        | 1 +
>>>>>  include/configs/mx53smd.h         | 1 +
>>>>>  include/configs/mx6_common.h      | 1 +
>>>>>  include/configs/p1_p2_rdb_pc.h    | 1 +
>>>>>  include/configs/p1_twr.h          | 1 +
>>>>>  include/configs/usbarmory.h       | 1 +
>>>>>  include/configs/vf610twr.h        | 1 +
>>>>>  include/configs/vision2.h         | 1 +
>>>>>  include/configs/woodburn_common.h | 1 +
>>>>>  44 files changed, 44 insertions(+), 1 deletion(-)
>>>>
>>>> Can you take a closer look at the powerpc boards? I think most of them
>>>> already calling get_clocks under this
>>>>
>>>> defined(CONFIG_PPC) && !defined(CONFIG_8xx_CPUCLK_DEFAULT)
>>>>
>>>> York
>>>
>>> I'm also confused about this. They have called get_clocks() twice on PPC 
>>> before even though they use CONFIG_FSL_ESDHC.
>>> I just made a replacement for it to keep the original meaning. 
>>> So where should get_clocks() be called correctly on PPC?
>>>
>>
>> It doesn't hurt to run twice for ppc. The second call is needed for 
>> Freescale
>> i.mx SoCs since it doesn't active the first one.
>>
>> Please test ppc targets without the change in header file.
> 
> Is there a reason why i.mx needs to call it later?  Is there a reason why PPC 
> needs to call it sooner?

I don't believe so. I prefer to see get_clocks moved under arch_cpu_init (we
need to make one for ppc though).

York