[U-Boot] [PATCHv3] arm: socfpga: Enable saveenv for SD/MMC

[Marek Vasut]

On Wednesday, September 23, 2015 at 09:21:48 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen at opensource.altera.com>
> 
> Enable the able to save the environment variables when SD/MMC is used.
> 
> Signed-off-by: Dinh Nguyen <dinguyen at opensource.altera.com>
> ---
> v3: Only define ENV_IS_NOWHERE if env is not in MMC, NAND, FAT, and
> SPI_FLASH v2: Move this option to be on a per-board basis
>     Add config for socfpga_cyclone5 and socfpga_arria5
> ---

[...]

Hi!

> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -281,7 +281,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
>  #define CONFIG_SYS_CONSOLE_IS_IN_ENV
>  #define CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE
>  #define CONFIG_SYS_CONSOLE_ENV_OVERWRITE
> +#if !defined CONFIG_ENV_IS_IN_MMC && \
> +    !defined CONFIG_ENV_IS_IN_NAND && \
> +    !defined CONFIG_ENV_IS_IN_FAT && \
> +    !defined CONFIG_ENV_IS_IN_SPI_FLASH

This really doesn't scale, I can have env in UBI for example, or on EEPROM
and this condition would trigger and cause a problem. Just move the
CONFIG_ENV_IS_NOWHERE into the respective board files and be done with it.
This bit of duplication is pretty OK I'd say.

>  #define CONFIG_ENV_IS_NOWHERE
> +#endif
>  #define CONFIG_ENV_SIZE			4096
> 
>  /*

[...]

Sorry to pester you this way, the rest is great of course :)

Best regards,
Marek Vasut