[U-Boot] [PATCH v7 6/6] spi: cadence_qspi: get fifo width from device tree

[Wolfgang Denk]

Dear Vikas Manocha,

In message <1443053976-9112-7-git-send-email-vikas.manocha at st.com> you wrote:
> Fifo width could be different on different socs, e.g. stv0991 & altera soc
> have different fifo width.
...
> --- a/drivers/spi/cadence_qspi.c
> +++ b/drivers/spi/cadence_qspi.c
> @@ -312,6 +312,7 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus)
>  	plat->tchsh_ns = fdtdec_get_int(blob, subnode, "tchsh-ns", 20);
>  	plat->tslch_ns = fdtdec_get_int(blob, subnode, "tslch-ns", 20);
>  	plat->sram_size = fdtdec_get_int(blob, node, "sram-size", 128);
> +	plat->fifo_width = fdtdec_get_int(blob, node, "cdns,fifo-width", 4);

Is using default values (which are known to be wrong on some
platforms) the right approach here?  It means that some systems will
silently misperform when the respective entries in the DT are missing.

Should we not add proper error handling here?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nobody trips over mountains. It is the small pebble that  causes  you
to  stumble.  Pass all the pebbles in your path and you will find you
have crossed the mountain.