[U-Boot] [PATCH 0/3] Fix fdt 'reg' parsing and unbreak Odroid U3

Przemyslaw Marczak p.marczak at samsung.com
Fri Sep 25 12:15:01 CEST 2015


Hello again,

On 09/25/2015 10:56 AM, Przemyslaw Marczak wrote:
> Hello,
>
> On 09/24/2015 05:29 PM, Przemyslaw Marczak wrote:
>> Booting of Odroid U3 with SD card, ends with error:
>>
>> MMC:   EXYNOS DWMMC: 0
>> Card did not respond to voltage select!
>> *** Warning - MMC init failed, using default environment
>>
>> Generally this was broken, because of wrong addresses assigned to GPIOs.
>>
>> The source of the problem was in rework of lib/fdtdec.c, after which
>> function fdtdec_get_addr() doesn't work as previous and function
>> dev_get_addr() doesn't works as expected.
>>
>> The code after rework in lib/fdtdec.c assume, that #size-cells property,
>> should be always greater or equal to 1. This was wrong, because it can
>> be 0.
>>
>> In case of debugging the issue I found, that mmc clock was computed
>> wrong,
>> for Exynos4, because of function get_mmc_clk(), which always return -1
>> for
>> this SoC.
>>
>> Tested on: Odroid U3 and Odroid XU3.
>>
>> Przemyslaw Marczak (3):
>>    fix: fdtdec: allow parse 'reg' property with zero value in
>>      '#size-cells'
>>    fix: s5p_gpio: call: dev_get_addr() instead of fdtdec_get_addr()
>>    fix: mach-exynos: clock: restore calling dead exynos4_get_mmc_clk()
>>
>>   arch/arm/mach-exynos/clock.c | 10 ++++------
>>   drivers/gpio/s5p_gpio.c      | 18 +++++++++++-------
>>   lib/fdtdec.c                 |  2 +-
>>   3 files changed, 16 insertions(+), 14 deletions(-)
>>
>
> +Tested-on: Odroid X2
>
> Best regards,

This patchset also fixes broken boot on Trats2. Probably the same for 
other Exynos4 boards.

+Tested-on: Trats2

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list