[U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

[Vikas MANOCHA]

Thanks Wolfgang,

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Thursday, September 24, 2015 3:32 PM
> To: Jagan Teki
> Cc: Vikas MANOCHA; u-boot at lists.denx.de; marex at denx.de; sr at denx.de;
> grmoore at opensource.altera.com
> Subject: Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base
> configuration in init
> 
> Dear Jagan,
> 
> In message <CAD6G_RSZAK7u=_ArT8SgqMvrdQ6ULi9szmxhF++kAEw-
> gv4Erw at mail.gmail.com> you wrote:
> >
> > What if we move Vikas changes now for this release as he stated in
> > previous mail "about sending patches later".
> 
> Well, we've been there too many times before.  In to many cases, the "later"
> just did not happen.

To ensure it this time, I can add a patch for the same on top of these patches in next version :-)

> 
> > My idea is someone is trying to clean it up existing code then give
> > him a chance to move his code as well because he sent couple times.
> 
> Well, I think it would be better to clean up first, instead of just reshuffeling
> the crappy code.
> 
> Also, I would like to hear a comment about comparing the efforts (and
> benefits) of cleaning up this stuff versus doing a clean port of the Linux
> version of that driver.

I think it makes sense.
Although both drivers (uboot, linux) have lot of similarities, there are differences also. It would be good to sync up.

Rgds,
Vikas

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Eureka!                                                 -- Archimedes