[U-Boot] [Patch v2 09/16] ARMv8/FSL_LSCH2: Add FSL_LSCH2 SoC

[Kushwaha Prabhakar]

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of York Sun
> Sent: Friday, September 25, 2015 8:23 PM
> To: Hu Mingkai-B21284 <Mingkai.Hu at freescale.com>; Gong Qianyu-B52263
> <Qianyu.Gong at freescale.com>; u-boot at lists.denx.de
> Cc: Wood Scott-B07421 <scottwood at freescale.com>; Li Yang-Leo-R58472
> <LeoLi at freescale.com>; Hou Zhiqiang-B48286 <B48286 at freescale.com>;
> Song Wenbin-B53747 <Wenbin.Song at freescale.com>
> Subject: Re: [U-Boot] [Patch v2 09/16] ARMv8/FSL_LSCH2: Add FSL_LSCH2
> SoC
> 
> 
> 
> On 09/25/2015 05:28 AM, Hu Mingkai-B21284 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Sun York-R58495
> >> Sent: Tuesday, September 22, 2015 1:27 AM
> >> To: Gong Qianyu-B52263; u-boot at lists.denx.de
> >> Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Song
> >> Wenbin- B53747; Xie Shaohui-B21989; Wood Scott-B07421; Li
> >> Yang-Leo-R58472
> >> Subject: Re: [Patch v2 09/16] ARMv8/FSL_LSCH2: Add FSL_LSCH2 SoC
> >>
> >>
> >>
> >> On 09/17/2015 12:06 AM, Gong Qianyu wrote:
> >>> From: Mingkai Hu <Mingkai.Hu at freescale.com>
> >>>
> >>> Freescale LayerScape with Chassis Generation 2 is a set of SoCs with
> >>> ARMv8 cores and 2rd generation of Chassis.
> >>>
> >>> Signed-off-by: Li Yang <leoli at freescale.com>
> >>> Signed-off-by: Hou Zhiqiang <B48286 at freescale.com>
> >>> Signed-off-by: Mingkai Hu <Mingkai.Hu at freescale.com>
> >>> Signed-off-by: Gong Qianyu <Qianyu.Gong at freescale.com>
> >>> ---
> >>> V2:
> >>> remove FSL_LS102xA_DEVDISR3_PCIE from immap_lsch2.h
> >>>
> >>>  arch/arm/cpu/armv8/Makefile                       |   1 +
> >>>  arch/arm/cpu/armv8/fsl-lsch2/Makefile             |  12 +
> >>>  arch/arm/cpu/armv8/fsl-lsch2/README               |  10 +
> >>>  arch/arm/cpu/armv8/fsl-lsch2/cpu.c                | 414
> >> ++++++++++++++++++
> >>
> >> Too much duplication. Please work with Alison/Prabhakar to move out
> >> the common code in cpu.c.
> >>
> >
> > I agree, there are too much duplications between lsch2 and lsch3:
> >
> > arch/arm/cpu/armv8/fsl-lsch*
> > arch/arm/include/asm/arch-fsl-lsch*
> >
> > I am considering to consolidate the code between lsch2 and lsch3 using
> arch-layerscape. The basic idea is to add the following directory for ARMv8
> layerscape for the common files and use CONFIG_FSL_LSCH2/
> CONFIG_FSL_LSCH3 to differentiate the difference between these two
> chassis in the same file if necessary.
> >
> > arch/arm/cpu/armv8/fsl-layerscape
> > arch/arm/include/asm/arch-fsl-layerscape/
> >
> > what is your suggestion?

Other than CONFIG_FSL_LSCH2 and CONFIG_FSL_LSCH3, we should also have CONFIG_FSL_LAYERSCAPE to enabled common code.

--prabhakar