[U-Boot] [PATCH v2 3/4] exynos: be more verbose in process_nodes()

[Przemyslaw Marczak]

Hello Tobias,

On 09/25/2015 07:18 PM, Tobias Jakobi wrote:
> In case sdhci_get_config() or do_sdhci_init() fail, show
> the error code that was returned.
>
> Signed-off-by: Tobias Jakobi <tjakobi at math.uni-bielefeld.de>
> ---
>   drivers/mmc/s5p_sdhci.c | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
> index b461fde..b60bc23 100644
> --- a/drivers/mmc/s5p_sdhci.c
> +++ b/drivers/mmc/s5p_sdhci.c
> @@ -171,7 +171,7 @@ static int sdhci_get_config(const void *blob, int node, struct sdhci_host *host)
>   static int process_nodes(const void *blob, int node_list[], int count)
>   {
>   	struct sdhci_host *host;
> -	int i, node;
> +	int i, node, ret;
>   	int failed = 0;
>
>   	debug("%s: count = %d\n", __func__, count);
> @@ -184,14 +184,16 @@ static int process_nodes(const void *blob, int node_list[], int count)
>
>   		host = &sdhci_host[i];
>
> -		if (sdhci_get_config(blob, node, host)) {
> -			printf("%s: failed to decode dev %d\n",	__func__, i);

> +		ret = sdhci_get_config(blob, node, host);
> +		if (ret) {
> +			printf("%s: failed to decode dev %d (%d)\n",	__func__, i, ret);
>   			failed++;
>   			continue;
>   		}
>
> -		if (do_sdhci_init(host)) {
> -			printf("%s: failed to initialize dev %d\n", __func__, i);
> +		ret = do_sdhci_init(host);
> +		if (ret) {
> +			printf("%s: failed to initialize dev %d (%d)\n", __func__, i, ret);
>   			failed++;
>   		}
>   	}
>

Acked-by: Przemyslaw Marczak <p.marczak at samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com