[U-Boot] [U-Boot, v2] tools: gen_eth_addr: add getpid() to time(0) to avoid duplicated seed

Tom Rini trini at konsulko.com
Mon Sep 28 23:08:36 CEST 2015


On Wed, Sep 16, 2015 at 06:21:04PM +0800, Josh Wu wrote:

> As 'time(0) | getpid()' will have a lot of duplicated value. It is not a
> expected behavior. We expect different value for the seed when when run
> it in many times.
> 
> So this patch will left shift the getpid() and add to time(0). That
> avoid duplicated value.
> 
> Test command is like:
>   % RUN=0; while [ $RUN -lt 10000 ]; do
>   tools/gen_eth_addr; RUN=$(($RUN+1)); done | sort | uniq | wc -l
>   10000
> 
> This patch is incorporated with suggestions made by Wolfgang Denk and Andreas
> Bießmann. Thanks them a lot.
> 
> Signed-off-by: Josh Wu <josh.wu at atmel.com>
> Acked-by: Andreas Bießmann <andreas.devel at googlemail.com>
> Acked-by: Wolfgang Denk <wd at denx.de>
> Tested-by: Wolfgang Denk <wd at denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150928/71531e23/attachment.sig>


More information about the U-Boot mailing list