[U-Boot] Antwort: Re: [PATCH] net: bootp fix vci string on SPL-Boot

[Hannes Schmelzer]

> Hi Hannes,
Hi Joe,

> On Tue, Sep 29, 2015 at 3:19 AM, Hannes Schmelzer
> <hannes at schmelzer.or.at> wrote:
> > Hi,
> >
> > just checked my upstream branch and noticed that this patch is 
outstanding.
> > How about merge?
> 
> Do you think this is a critical bug fix? I was planning to wait for
> next release since the patch came after the merge window.

Absolutely not critical. no problem to wait for next release.

> 
> > regards,
> > Hannes
> >
> >
> >
> > On 25.08.2015 18:01, Joe Hershberger wrote:
> >>
> >> Hi Hannes,
> >>
> >> On Tue, Aug 25, 2015 at 5:17 AM, Hannes Schmelzer <oe5hpm at oevsv.at> 
wrote:
> >>>
> >>> If CONFIG_CMD_DHCP is enabled, the vci (vendor-class-identifier) 
string
> >>> isn't inserted into the bootp-packet during SPL stage because the
> >>>
> >>> CONFIG_BOOTP_VCI_STRING
> >>> instead
> >>> CONFIG_SPL_NET_VCI_STRING
> >>>
> >>> We fix this with testing for CONFIG_SPL_BUILD and testing for 
existing
> >>> CONFIG_SPL_NET_VCI_STRING.
> >>>
> >>> Signed-off-by: Hannes Schmelzer <oe5hpm at oevsv.at>
> >>
> >> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> >>
> >>
> >