[U-Boot] [PATCH] image-fit: Change FIT prefix for configurations

Tom Rini trini at konsulko.com
Fri Apr 1 22:53:57 CEST 2016


On Thu, Mar 17, 2016 at 02:05:59PM +0000, Sáreník Ján wrote:

> Instead of `bootm ${loadaddr}#conf at 1`
> one uses   `bootm ${loadaddr}_conf at 1`
> 
> This fixes the bug with using just `bootm #conf at 2`
> without $loadaddr where text starting with # is
> interpreted as a comment.
[snip]
> diff --git a/doc/uImage.FIT/command_syntax_extensions.txt b/doc/uImage.FIT/command_syntax_extensions.txt
> index 6c99b1c..ef4db80 100644
> --- a/doc/uImage.FIT/command_syntax_extensions.txt
> +++ b/doc/uImage.FIT/command_syntax_extensions.txt
> @@ -36,7 +36,7 @@ Old uImage:
>  New uImage:
>  8.  bootm <addr1>
>  9.  bootm [<addr1>]:<subimg1>
> -10. bootm [<addr1>]#<conf>
> +10. bootm [<addr1>]_<conf>
>  11. bootm [<addr1>]:<subimg1> [<addr2>]:<subimg2>
>  12. bootm [<addr1>]:<subimg1> [<addr2>]:<subimg2> [<addr3>]:<subimg3>
>  13. bootm [<addr1>]:<subimg1> [<addr2>]:<subimg2> <addr3>

So the bug you've found is that we don't parse "bootm #conf at 2"
correctly.  We cannot change what has been working and is likely in the
wild of "bootm ${loadaddr}#conf at 2".  I think what we have to do here is
correct the syntax file here to note that addr1 is not optional in that
case and add a new form.  I would first suggest seeing how it looks in
code to have "bootm conf at 2" just work.   If it ends up being too tricky
or complex, "bootm _conf@" is OK as the new one.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160401/77573300/attachment.sig>


More information about the U-Boot mailing list