[U-Boot] [U-Boot, v3, 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled

Stefan Roese sr at denx.de
Mon Apr 4 12:16:14 CEST 2016


Hi Simon, Hi Tom!

On 02.04.2016 03:55, Tom Rini wrote:
> On Sat, Mar 19, 2016 at 02:18:38AM -0600, Simon Glass wrote:
>
>> Command parsing and processing code is not needed when the command line is
>> disabled. Remove this code in that case.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> Reviewed-by: Tom Rini <trini at konsulko.com>
>
> Applied to u-boot/master, thanks!

I just noticed that this patch breaks U-Boot on some boards. All that
don't have CONFIG_SYS_HUSH_PARSER or CONFIG_CMDLINE enabled (e.g.
some MVEBU board, like the "db-mv784mp-gp".

How should this be solved? Should we enable CONFIG_CMDLINE per
default (via config_defaults.h ?)? Or should we enable CONFIG_CMDLINE
in all board config headers that are currently missing it?

Thanks,
Stefan


More information about the U-Boot mailing list