[U-Boot] [U-Boot, v3, 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled

[Simon Glass]

Hi Stefan,

On 5 April 2016 at 01:38, Stefan Roese <sr at denx.de> wrote:
>
> Hi Simon,
>
> On 04.04.2016 15:18, Simon Glass wrote:
>>
>> On Apr 4, 2016 03:16, "Stefan Roese" <sr at denx.de <mailto:sr at denx.de>> wrote:
>>  >
>>  > Hi Simon, Hi Tom!
>>  >
>>  >
>>  > On 02.04.2016 03:55, Tom Rini wrote:
>>  >>
>>  >> On Sat, Mar 19, 2016 at 02:18:38AM -0600, Simon Glass wrote:
>>  >>
>>  >>> Command parsing and processing code is not needed when the command
>> line is
>>  >>> disabled. Remove this code in that case.
>>  >>>
>>  >>> Signed-off-by: Simon Glass <sjg at chromium.org <mailto:sjg at chromium.org>>
>>  >>> Reviewed-by: Tom Rini <trini at konsulko.com <mailto:trini at konsulko.com>>
>>  >>
>>  >>
>>  >> Applied to u-boot/master, thanks!
>>  >
>>  >
>>  > I just noticed that this patch breaks U-Boot on some boards. All that
>>  > don't have CONFIG_SYS_HUSH_PARSER or CONFIG_CMDLINE enabled (e.g.
>>  > some MVEBU board, like the "db-mv784mp-gp".
>>  >
>>  > How should this be solved? Should we enable CONFIG_CMDLINE per
>>  > default (via config_defaults.h ?)? Or should we enable CONFIG_CMDLINE
>>  > in all board config headers that are currently missing it?
>>
>> All boards should have CONFIG_CMDLINE enables by default.
>
>
> That's currently not the case. At least some MVEBU (Armada XP / 38x)
> boards don't have it enabled. Here a short (most likely incomplete)
> list:
>
> clearfog

$ crosfw -b clearfog -w
$ grep CMDLINE b/clearfog/.config
CONFIG_CMDLINE=y

Also see cmd/Kconfig, where is defaults to y.

> db-88f6820-gp
> db-mv784mp-gp_defconfig
> ds414
> maxbcm
>
> And probably some (most?) Orion & Kirkwood based board as well. I
> assume that most boards that include "mv-common.h" have it not
> enabled (I didn't check all of them).
>
> Some board, like theadorable have HUSH support enabled but
> CMDLINE not. These boards are not broken.
>
>> Is the problem
>> with the build or at run-time?
>
>
> Run-time.

OK so I wonder if the problem is not the option itself but something
in the command line code for the non-hush parser? If you enable hush
does it work? What exactly is the failure?

Regards,
Simon