[U-Boot] [PATCH 7/7] gpio: tegra: remove flags parsing in xlate routine

Stephen Warren swarren at wwwdotorg.org
Wed Apr 6 00:09:55 CEST 2016


On 04/01/2016 09:47 AM, Eric Nelson wrote:
> With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, it is
> no longer necessary for the tegra-specific xlate function to do this.

> diff --git a/drivers/gpio/tegra_gpio.c b/drivers/gpio/tegra_gpio.c

> @@ -246,7 +246,6 @@ static int tegra_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
>   	if (ret)
>   		return ret;
>   	desc->offset = gpio % TEGRA_GPIOS_PER_PORT;
> -	desc->flags = args->args[1] & GPIO_ACTIVE_LOW ? GPIOD_ACTIVE_LOW : 0;

I expect that after that, you can also remove the following at the top 
of the file:

#include <dt-bindings/gpio/gpio.h>

I expect that's true of other GPIO drivers too.



More information about the U-Boot mailing list