[U-Boot] [PATCH v2] kirkwood_nand: claim MPP pins on the fly

Stefan Roese sr at denx.de
Wed Apr 6 15:42:49 CEST 2016


On 05.04.2016 00:48, Scott Wood wrote:
> On 03/24/2016 03:40 AM, Stefan Roese wrote:
>> On 02.02.2016 00:35, Chris Packham wrote:
>>> Claim the MPP pins for the NAND flash controller only when it's actually
>>> being used. This allows the pins to be shared with the SPI interface
>>> which already supports an equivalent on-access MPP reconfiguration.
>>>
>>> Reviewed-by: Mark Tomlinson <mark.tomlinson at alliedtelesis.co.nz>
>>> Signed-off-by: Chris Packham <judge.packham at gmail.com>
>>> ---
>>> I haven't wrapped this with a configuration option because I think it
>>> should be safe to enable by default. It will either re-apply the same
>>> MPP configuration that has already been done in the board init or put
>>> the MPP pins into the correct mode to access NAND.
>>>
>>> I've only got access to one kirkwood based board with NAND flash so I'd
>>> appreciate some feedback from someone with access to a few different
>>> boards.
>>>
>>>   From the datasheets I have access to it looks like there is only one
>>> possible MPP configuration for NF_IO[0-7] so that is what I've
>>> implemented. I'm not aware of anything using this driver that needs a
>>> different MPP config.
>>>
>>> Changes in v2:
>>> - make nand_config static const
>>
>> Scott, are you okay with this patch in v2?
>
> Yes.
> Acked-by: Scott Wood <oss at buserror.net>
>
>> If yes, will you pull it?
>> Or should I include it in a marvell pull request?
>
> Go ahead.

Applied to u-boot-marvell/master.

Thanks,
Stefan



More information about the U-Boot mailing list