[U-Boot] [PATCH 0/5] tools/env: pass arguments as parameters not global structure

Stefano Babic sbabic at denx.de
Wed Apr 6 16:25:52 CEST 2016


Hi Andreas,

On 05/04/2016 23:13, Andreas Fenkart wrote:
> u-boot tools can be built as a library (ibubootenv.a). Passing arguments
> to the library using global structures is not a good interface.
> 
> Andreas Fenkart (5):
>   tools/env: make env_aes_cbc_crypt re-entrant
>   tools/env: remove 'extern' from function prototype in fw_env.h
>   tools/env: fw_printenv pass value_only as argument
>   tools/env: compute size of usable area only once
>   tools/env: no global variable sharing between application and library
> 
>  tools/env/fw_env.c      | 95 ++++++++++++++++++++++++++-----------------------
>  tools/env/fw_env.h      | 31 ++++++----------
>  tools/env/fw_env_main.c | 28 +++++++++------
>  3 files changed, 78 insertions(+), 76 deletions(-)
> 

I can confirm that series fixes building an external program using the
env tools as environment. Thanks for fixing it !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list