[U-Boot] [PATCH] armv8/ls1043a: Add MTD partition scheme

[Wenbin Song]

Hi: York

Do you mean that I should use $mtdpart to instead of "MTDPARTS_DEFAULT" ?
 
As follows:	
       #define CONFIG_BOOTARGS                 "console=ttyS0,115200 root=/dev/ram0 " \
	                                         "earlycon=uart8250,mmio,0x21c0500 " \
	                                       "$mtdparts"

If so, the variable $mtdparts can't  be extend ,like that:

root at ls1043aqds:~# cat /proc/cmdline
console=ttyS0,115200 root=/dev/ram0 earlycon=uart8250,mmio,0x21c0500 ${mtdparts}


Best Regards
Wenbin Song


> -----Original Message-----
> From: York Sun [mailto:york.sun at nxp.com]
> Sent: Wednesday, April 06, 2016 4:33 AM
> To: Wenbin Song <wenbin.song at nxp.com>; Mingkai Hu
> <mingkai.hu at nxp.com>; u-boot at lists.denx.de
> Cc: Qianyu Gong <qianyu.gong at nxp.com>; Shaohui Xie
> <shaohui.xie at nxp.com>; Zhiqiang Hou <zhiqiang.hou at nxp.com>
> Subject: Re: [PATCH] armv8/ls1043a: Add MTD partition scheme
> 
> On 04/01/2016 02:37 AM, Wenbin Song wrote:
> > Add and share the the MTD partition scheme with kernel by defualt bootargs.
> > And add the "mtdparts" env.
> >
> > Signed-off-by: Wenbin Song <wenbin.song at nxp.com>
> > ---
> >  include/configs/ls1043a_common.h | 22 ++++++++++++++++++++--
> >  1 file changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/configs/ls1043a_common.h
> > b/include/configs/ls1043a_common.h
> > index fd243b1..6964873 100644
> > --- a/include/configs/ls1043a_common.h
> > +++ b/include/configs/ls1043a_common.h
> > @@ -236,6 +236,21 @@
> >  #define CONFIG_HWCONFIG
> >  #define HWCONFIG_BUFFER_SIZE		128
> >
> > +#if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_SD_BOOT_QSPI)
> #define
> > +MTDPARTS_DEFAULT "mtdparts=spi0.0:1m(uboot)," \
> > +			"5m(kernel),1m(dtb),9m(file_system)"
> > +#else
> > +#define MTDPARTS_DEFAULT
> "mtdparts=60000000.nor:1m(nor_bank0_rcw)," \
> > +			"1m(nor_bank0_uboot),1m(nor_bank0_uboot_env),"
> \
> > +			"1m(nor_bank0_fman_uconde),40m(nor_bank0_fit),"
> \
> > +			"1m(nor_bank4_rcw),1m(nor_bank4_uboot)," \
> > +
> 	"1m(nor_bank4_uboot_env),1m(nor_bank4_fman_ucode)," \
> > +			"40m(nor_bank4_fit);7e800000.flash:" \
> > +			"1m(nand_uboot),1m(nand_uboot_env)," \
> > +			"20m(nand_fit);spi0.0:1m(uboot)," \
> > +			"5m(kernel),1m(dtb),9m(file_system)"
> > +#endif
> > +
> >  /* Initial environment variables */
> >  #define CONFIG_EXTRA_ENV_SETTINGS		\
> >  	"hwconfig=fsl_ddr:bank_intlv=auto\0"	\
> > @@ -248,10 +263,13 @@
> >  	"kernel_start=0x61100000\0"		\
> >  	"kernel_load=0xa0000000\0"		\
> >  	"kernel_size=0x2800000\0"		\
> > -	"console=ttyAMA0,38400n8\0"
> > +	"console=ttyAMA0,38400n8\0"		\
> > +	"mtdparts=" MTDPARTS_DEFAULT "\0"
> >
> >  #define CONFIG_BOOTARGS			"console=ttyS0,115200
> root=/dev/ram0 " \
> > -					"earlycon=uart8250,mmio,0x21c0500"
> > +					"earlycon=uart8250,mmio,0x21c0500 " \
> > +					MTDPARTS_DEFAULT
> 
> You could use $mtdparts here so your bootcmd doesn't get too long.
> 
> York