[U-Boot] [PATCH v3 1/1] mpc85xx: Enable pre-relocation malloc for MPC85xx

Mario Six mario.six at gdsys.cc
Thu Apr 7 08:06:00 CEST 2016


Quoting York Sun <york.sun at nxp.com>:

> On 04/05/2016 06:06 AM, Mario Six wrote:
>> To enable DM on MPC85xx, we need pre-relocation malloc, which is
>> implemented in this patch.
>>
>> We also make sure that the IVORs are always 4-aligned on e500 to prevent
>> alignment exceptions caused by code changes in start.S.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>> Cc: York Sun <york.sun at nxp.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> ---
>>
>> v3:
>>  - Add comment regarding gd zeroing
>>  - Unconditionally zero out initial RAM during startup
>>
>> v2:
>>  - Correct IVOR alignment and remove nop hack
>>  - Add sanity check for length of malloc area
>>
>>
>>  arch/powerpc/cpu/mpc85xx/cpu_init_early.c |  8 +-------
>>  arch/powerpc/cpu/mpc85xx/start.S          | 30  
>> ++++++++++++++++++++++++++++++
>>  include/ppc_asm.tmpl                      |  3 +++
>>  3 files changed, 34 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c  
>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>> index 235a635..85b4112 100644
>> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>> @@ -82,7 +82,6 @@ void setup_ifc(void)
>>  void cpu_init_early_f(void *fdt)
>>  {
>>  	u32 mas0, mas1, mas2, mas3, mas7;
>> -	int i;
>
> This causes a problem. Variable "i" is still used at line 158.
> I can fix it unless you want to respin the patch.
>
> York

Just fix it; no need to go through the whole procedure again for  
something like
that :-)

Thanks for all the help and best regards,

Mario



More information about the U-Boot mailing list