[U-Boot] [PATCH] USB: g_dnl: Change device class

Lukasz Majewski l.majewski at samsung.com
Fri Apr 8 11:19:34 CEST 2016


Hi John,

> The USB Mass Storage (ums) works in Windows, Linux and OS X (EL
> Capitan). But, not in OS X (Yosemite). By applying the said patch, it
> extends the ums support.
> 
> Signed-off-by: John Tobias <john.tobias.ph at gmail.com>
> ---
>  drivers/usb/gadget/g_dnl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> index 2fa6da4..bd3aad9 100644
> --- a/drivers/usb/gadget/g_dnl.c
> +++ b/drivers/usb/gadget/g_dnl.c
> @@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc = {
>  	.bDescriptorType = USB_DT_DEVICE,
>  
>  	.bcdUSB = __constant_cpu_to_le16(0x0200),
> -	.bDeviceClass = USB_CLASS_COMM,
> -	.bDeviceSubClass = 0x02, /*0x02:CDC-modem , 0x00:CDC-serial*/
> +	.bDeviceClass = USB_CLASS_PER_INTERFACE,
> +	.bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/

Have you tested if this patch is not introducing any regression on
Linux and Windows?

>  
>  	.idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM),
>  	.idProduct =
> __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM),



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list