[U-Boot] [PATCH 06/10] ddr: altera: Remove unnecessary ODT mode config

George Broz brozgeo at gmail.com
Sat Apr 9 00:14:32 CEST 2016


On 6 April 2016 at 19:04, Marek Vasut <marex at denx.de> wrote:
> There is no point in resetting the ODT setting if the write test
> failed, since the code will always retry the calibration and thus
> reconfigure the ODT anyway OR the code will fail calibration and
> halt.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> Cc: Chin Liang See <clsee at altera.com>
> ---
>  drivers/ddr/altera/sequencer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
> index 6bf75ba..254b130 100644
> --- a/drivers/ddr/altera/sequencer.c
> +++ b/drivers/ddr/altera/sequencer.c
> @@ -1207,7 +1207,6 @@ rw_mgr_mem_calibrate_write_test(const u32 rank_bgn, const u32 write_group,
>                            *bit_chk == param->write_correct_mask);
>                 return *bit_chk == param->write_correct_mask;
>         } else {
> -               set_rank_and_odt_mask(0, RW_MGR_ODT_MODE_OFF);
>                 debug_cond(DLEVEL == 2,
>                            "write_test(%u,%u,ONE) : %u != %i => %i\n",
>                            write_group, use_dm, *bit_chk, 0, *bit_chk != 0);
> --
> 2.7.0
>

Tested on: SoCKit, DE0_Nano_SoC
Tested-by: George Broz <brozgeo at gmail.com>


More information about the U-Boot mailing list