[U-Boot] [uboot] [PATCH 7/7] net: phy: dp83867: Add SGMII helper for configuration

Michal Simek michal.simek at xilinx.com
Mon Apr 11 09:06:57 CEST 2016


On 8.4.2016 18:08, Dan Murphy wrote:
> The code assumed that if the interface is not RGMII configured
> then it must be SGMII configured.  This device has the ability
> to support most of the MII interfaces.  Therefore add the
> helper for SGMII and only configure the device if the interface is
> configured for SGMII.
> 
> Signed-off-by: Dan Murphy <dmurphy at ti.com>
> ---
>  drivers/net/phy/ti.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c
> index d503eef..4402c52 100644
> --- a/drivers/net/phy/ti.c
> +++ b/drivers/net/phy/ti.c
> @@ -219,7 +219,7 @@ static int dp83867_config(struct phy_device *phydev)
>  			(dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT));
>  		if (ret)
>  			goto err_out;
> -	} else {
> +	} else if (phy_interface_is_sgmii(phydev)) {
>  		phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR,
>  			  (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000));
>  
> 

Reviewed-by: Michal Simek <michal.simek at xilinx.com>

Thanks,
Michal


More information about the U-Boot mailing list