[U-Boot] [U-Boot, v2, 1/2] arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code

[Tom Rini]

On Sat, Apr 09, 2016 at 01:53:48PM +0200, Hans de Goede wrote:

> v7_maint_dcache_all() does not work reliable when build with gcc6,
> see: https://bugzilla.redhat.com/show_bug.cgi?id=1318788
> 
> While debugging this I learned that v7_maint_dcache_all() is unreliable
> when build with gcc5 too when it is marked as noinline.
> 
> This commit fixes the reliability issues by replacing the C-code with
> the ready to use asm implementation from the kernel.
> 
> Given that this code when written as C-code clearly is quite fragile
> (also see the existing comments about the C-code being the way it is
>  to get optimal assembly) and that we have a proven asm alternative,
> I believe that this is the best solution.
> 
> Note that we actually already had a copy of the kernel's
> v7_flush_dcache_all() before this commit in
> arch/arm/mach-uniphier/arm32/lowlevel_init.S.
> 
> This commit moves that code arch/arm/cpu/armv7/cache_v7_asm.S, renames
> it to __v7_flush_dcache_all(), and adds a v7_flush_dcache_all() wrapper
> which saves / restores the clobbered registers for use from C-code.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Acked-by: Masahiro Yamada <yamada.masahiro at socionext.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160411/2a39bb5c/attachment.sig>