[U-Boot] [PATCH] efi_loader: Use system fdt as fallback

Andreas Färber afaerber at suse.de
Wed Apr 13 15:17:41 CEST 2016


Am 13.04.2016 um 15:15 schrieb Alexander Graf:
> On 04/13/2016 02:58 PM, Andreas Färber wrote:
>> Am 11.04.2016 um 16:55 schrieb Alexander Graf:
>>> When the user did not pass any device tree or the boot script
>>> didn't find any, let's use the system device tree as last resort
>>> to get something the payload (Linux) may understand.
>>>
>>> This means that on systems that use the same device tree for U-Boot
>>> and Linux we can just share it and there's no need to manually provide
>>> a device tree in the target image.
>>>
>>> While at it, also copy and pad the device tree by 64kb to give us
>>> space for modifications.
>>>
>>> Signed-off-by: Alexander Graf <agraf at suse.de>
>> Tested-by: Andreas Färber <afaerber at suse.de>
>>
>> It definitely avoids a warning message. However, it does not always
>> allow Linux to actually boot, e.g. on jetson-tk1 (patch sent).
> 
> We could give the user a warning in the fallback case as well, but
> ideally I'd like to move to a model where all device trees really are
> interchangable and work with every component. So then we would warn the
> user about the preferred default case. I'm not sure that's a great idea.

I'm not saying we need a warning here, just that this solution by itself
is not sufficient and other fixes (like supplying $fdtfile) are still
necessary today.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)


More information about the U-Boot mailing list