[U-Boot] [PATCH v2 1/3] tests: py: dfu: Add global variables to store dfu alt numbers for test and dummy files

Lukasz Majewski l.majewski at samsung.com
Tue Apr 19 18:30:12 CEST 2016


Hi Stephen,

> On 04/19/2016 09:51 AM, Lukasz Majewski wrote:
> > This patch replaces hardcoded (i.e. 0 and 1) values passed to
> > dfu_{read|write} with global variables.
> 
> Why do these variables need to be global? They're only used inside 
> test_dfu(). They should be local to that function.
> 

Ok, I will fix that.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list