[U-Boot] [PATCH] debug_uart: output CR along with LF

[Simon Glass]

Hi Tim,

On 7 April 2016 at 11:20, Tim Chick <Tim.Chick at mediatek.com> wrote:
> Sorry for top posting. Not in the office at the moment.
>
> Yes, I call debug_uart_init() before I have SDRAM, in lowlevel_init(). I
> need the debug uart to help me debug lowlevel_init!
>
> Thanks,
> Tim
>
>
> -----Original Message-----
> From: Daniel Schwierzeck [mailto:daniel.schwierzeck at gmail.com]
> Sent: 07 April 2016 17:48
> To: Tim Chick <Tim.Chick at mediatek.com>
> Cc: yamada.masahiro at socionext.com; u-boot at lists.denx.de; Simon Glass
> <sjg at chromium.org>; Stefan Roese <sr at denx.de>
> Subject: Re: [U-Boot] [PATCH] debug_uart: output CR along with LF
>
> Hi Tim,
>
> 2016-04-04 17:16 GMT+02:00 Tim Chick <Tim.Chick at mediatek.com>:
>> Hi Masahiro,
>>
>> This patch breaks the debug_uart on my MIPS board. It means printascii now
>> uses the stack, and my board does not have a stack when debug_uart_init is
>> called. debug_uart_init calls printascii if DEBUG_UART_ANNOUNCE is defined.
>
> do you call debug_uart_init() in lowlevel_init()?
>
>>
>> The patch below fixes it, and keeps your change:

Yes your patch looks correct to me. I have also used the debug UART
without a stack.

Reviewed-by: Simon Glass <sjg at chromium.org>

>>
>> Thanks,
>> Tim
>>
>>
>> ---
>>
>> diff --git a/include/debug_uart.h b/include/debug_uart.h
>> index 0d640b9..2980ae6 100644
>> --- a/include/debug_uart.h
>> +++ b/include/debug_uart.h
>> @@ -115,17 +115,23 @@ void printhex8(uint value);
>>   * Now define some functions - this should be inserted into the serial
>> driver
>>   */
>>  #define DEBUG_UART_FUNCS \
>> -       void printch(int ch) \
>> +\
>> +       static inline void _printch(int ch) \
>>         { \
>>                 if (ch == '\n') \
>>                         _debug_uart_putc('\r'); \
>>                 _debug_uart_putc(ch); \
>>         } \
>>  \
>> +       void printch(int ch) \
>> +       { \
>> +               _printch(ch); \
>> +       } \
>> +\
>>         void printascii(const char *str) \
>>         { \
>>                 while (*str) \
>> -                       printch(*str++); \
>> +                       _printch(*str++); \
>>         } \
>>  \
>>         static inline void printhex1(uint digit) \
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
> --
> - Daniel
>
> ************* Email Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!