[U-Boot] [PATCH] serial: bcm283x_mu: make pending values more explicit

Simon Glass sjg at chromium.org
Wed Apr 20 16:41:32 CEST 2016


On 13 April 2016 at 22:29, Stephen Warren <swarren at wwwdotorg.org> wrote:
> dm_serial_ops.pending should return the number of characters, not just a
> valid C Boolean integer value. The existing code does already does this,
> but only as an accident since BCM283X_MU_LSR_RX_READY happens to be
> BIT(0). Enhance the code to be more explicit about the values it returns.
>
> Suggested-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
> ---
>  drivers/serial/serial_bcm283x_mu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list