[U-Boot] [PATCH] x86: qemu: Drop our own ACPI implementation

[Saket Sinha]

Hi Simon,

Do you want me to rework this with DM PCI ?
Regards,
Saket Sinha


On Wed, Apr 20, 2016 at 6:43 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 13 April 2016 at 01:52, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Our own ACPI implementation (when CONFIG_QEMU_ACPI_TABLE is not set)
>> does not build anymore after x86 has been fully converted to DM PCI.
>> Instead of trying to fix the build errors, given we now have the ACPI
>> support via QEMU's fw_cfg interface, which is a more reliable way to
>> generate correct ACPI tables then by ourselves, hence drop our own
>> ACPI implementation.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> ---
>>
>> arch/x86/cpu/qemu/Makefile | 3 -
>> arch/x86/cpu/qemu/acpi.c | 176 --------------
>> arch/x86/cpu/qemu/acpi/cpu-hotplug.asl | 80 -------
>> arch/x86/cpu/qemu/acpi/dbug.asl | 25 --
>> arch/x86/cpu/qemu/acpi/hpet.asl | 31 ---
>> arch/x86/cpu/qemu/acpi/isa.asl | 102 --------
>> arch/x86/cpu/qemu/acpi/pci-crs.asl | 61 -----
>> arch/x86/cpu/qemu/dsdt.asl | 412 ---------------------------------
>> 8 files changed, 890 deletions(-)
>> delete mode 100644 arch/x86/cpu/qemu/acpi.c
>> delete mode 100644 arch/x86/cpu/qemu/acpi/cpu-hotplug.asl
>> delete mode 100644 arch/x86/cpu/qemu/acpi/dbug.asl
>> delete mode 100644 arch/x86/cpu/qemu/acpi/hpet.asl
>> delete mode 100644 arch/x86/cpu/qemu/acpi/isa.asl
>> delete mode 100644 arch/x86/cpu/qemu/acpi/pci-crs.asl
>> delete mode 100644 arch/x86/cpu/qemu/dsdt.asl
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> My only concern is that this was supposed to lead to ACPI support for real
> hardware. If you drop this, does it make it harder?
>
> Regards,
> Simon