[U-Boot] [PATCH 3/3] usb: s3c-otg: Fix remaining bytes in debug messages

Steve Rae steve.rae at broadcom.com
Fri Apr 22 05:03:38 CEST 2016


On Thu, Apr 21, 2016 at 7:49 PM, Steve Rae <steve.rae at broadcom.com> wrote:

>
>
> On Thu, Apr 21, 2016 at 3:05 AM, Lukasz Majewski <l.majewski at samsung.com>
> wrote:
>
>> Hi Roger,
>>
>> > Remaining bytes means bytes that are not yet transferred
>> > and not the bytes that were transferred in the last transfer.
>> >
>> > Reported-by: Lukasz Majewski <l.majewski at samsung.com>
>> > Signed-off-by: Roger Quadros <rogerq at ti.com>
>> > ---
>> >  drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
>> > b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c index a31d875..0594c3d
>> > 100644 --- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
>> > +++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
>> > @@ -235,7 +235,7 @@ static void complete_rx(struct dwc2_udc *dev, u8
>> > ep_num) "%s: RX DMA done : ep = %d, rx bytes = %d/%d, "
>> >                  "is_short = %d, DOEPTSIZ = 0x%x, remained bytes =
>> > %d\n", __func__, ep_num, req->req.actual, req->req.length,
>> > -                is_short, ep_tsr, xfer_size);
>> > +                is_short, ep_tsr, req->req.length -
>> > req->req.actual);
>> >       if (is_short || req->req.actual == req->req.length) {
>> >               if (ep_num == EP0_CON && dev->ep0state ==
>> > DATA_STATE_RECV) { @@ -292,7 +292,7 @@ static void complete_tx(struct
>> > dwc2_udc *dev, u8 ep_num) "%s: TX DMA done : ep = %d, tx bytes =
>> > %d/%d, " "is_short = %d, DIEPTSIZ = 0x%x, remained bytes = %d\n",
>> >               __func__, ep_num, req->req.actual, req->req.length,
>> > -             is_short, ep_tsr, xfer_size);
>> > +             is_short, ep_tsr, req->req.length - req->req.actual);
>> >
>> >       if (ep_num == 0) {
>> >               if (dev->ep0state == DATA_STATE_XMIT) {
>>
>> Acked-by: Lukasz Majewski <l.majewski at samsung.com>
>>
>> Tested-by: Steve Rae <srae at broadcom.com>
> [Test HW: bcm28155_ap board]
>
> Thanks, Steve
>

retry because patchworks missed this....

Tested-by: Steve Rae <srae at broadcom.com>
[Test HW: bcm28155_ap board]



>
>
>> --
>> Best regards,
>>
>> Lukasz Majewski
>>
>> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
>>
>
>


More information about the U-Boot mailing list